Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider Version method #98

Closed
alexvanin opened this issue Jun 24, 2021 · 1 comment · Fixed by #118
Closed

Reconsider Version method #98

alexvanin opened this issue Jun 24, 2021 · 1 comment · Fixed by #118
Assignees
@alexvanin
Milestone
v0.10.1

Comments

@alexvanin
Copy link
Contributor

This repository uses semver, however contract's Version methods do not reflect it by any meaning. We are trying to migrate contracts in testnet from release to release without script hash changes, but right now we can't say for sure what release version is deployed and running at this moment.

As an option we can change signature of Version method and return semver string.
@alexvanin
Copy link
Contributor Author

Encode semver into single int:

version = major * 1 000 000 + minor * 1 000 + patch

@alexvanin alexvanin mentioned this issue Jul 29, 2021
Merged
@alexvanin alexvanin mentioned this issue Oct 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexvanin alexvanin

Labels
None yet
Projects
None yet
Milestone
v0.10.1
Development

Successfully merging a pull request may close this issue.

Encode semver in version number
1 participant
@alexvanin