Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Strange stats on some errors #655

Open
cthulhu-rider opened this issue Dec 9, 2024 · 1 comment
Open

client: Strange stats on some errors #655

cthulhu-rider opened this issue Dec 9, 2024 · 1 comment
Labels
bug Something isn't working client Issue related to the client I4 No visible changes S4 Routine U2 Seriously planned
Milestone

Comments

@cthulhu-rider
Copy link
Contributor

https://pkg.go.dev/github.com/nspcc-dev/neofs-sdk-go/client#PrmInit.SetStatisticCallback option allows to enable internal tracktion of op execution. For some errors, submitted stats look like a successful op completed insta

for example, ObjectDelete on ErrMissingSigner

Current Behavior

some errors are nil-ed and still submitted to the stat handler. With this, such results cannot differ from OK in general. At the same time, some homogeneous errors are transmitted as is (e.g. ObjectHash)

Expected Behavior

either

  1. skip stats for invalid input completely
  2. pass any error to the handler as it is

Possible Solution

i can suppose that it was an attempt to implement 1 to exclude user input errors which is not w/o sense. But for this I'd introduce a classification of errors accessible to the external user and let him decide for himself. Although in this case the internal stats lose their meaning becoming completely implementable around the base client

afaik all current errors are exported and documented, so 2 can be done

Steps to Reproduce

see exec statistics tests from #641

Regression

no i guess

Your Environment

  • Version of the product used: 335d9fe
@cthulhu-rider cthulhu-rider added bug Something isn't working client Issue related to the client labels Dec 9, 2024
@roman-khimov
Copy link
Member

2 is the right thing to do here. It is a call. It has an error and time of some kind.

@roman-khimov roman-khimov added U2 Seriously planned S4 Routine I4 No visible changes labels Dec 9, 2024
@roman-khimov roman-khimov added this to the v1.0.0-rc13 milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client Issue related to the client I4 No visible changes S4 Routine U2 Seriously planned
Projects
None yet
Development

No branches or pull requests

2 participants