You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
some errors are nil-ed and still submitted to the stat handler. With this, such results cannot differ from OK in general. At the same time, some homogeneous errors are transmitted as is (e.g. ObjectHash)
Expected Behavior
either
skip stats for invalid input completely
pass any error to the handler as it is
Possible Solution
i can suppose that it was an attempt to implement 1 to exclude user input errors which is not w/o sense. But for this I'd introduce a classification of errors accessible to the external user and let him decide for himself. Although in this case the internal stats lose their meaning becoming completely implementable around the base client
afaik all current errors are exported and documented, so 2 can be done
https://pkg.go.dev/github.com/nspcc-dev/neofs-sdk-go/client#PrmInit.SetStatisticCallback option allows to enable internal tracktion of op execution. For some errors, submitted stats look like a successful op completed insta
for example,
ObjectDelete
onErrMissingSigner
Current Behavior
some errors are nil-ed and still submitted to the stat handler. With this, such results cannot differ from OK in general. At the same time, some homogeneous errors are transmitted as is (e.g.
ObjectHash
)Expected Behavior
either
Possible Solution
i can suppose that it was an attempt to implement 1 to exclude user input errors which is not w/o sense. But for this I'd introduce a classification of errors accessible to the external user and let him decide for himself. Although in this case the internal stats lose their meaning becoming completely implementable around the base client
afaik all current errors are exported and documented, so 2 can be done
Steps to Reproduce
see
exec statistics
tests from #641Regression
no i guess
Your Environment
The text was updated successfully, but these errors were encountered: