Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Object search response payload is unverified #657

Open
cthulhu-rider opened this issue Dec 9, 2024 · 0 comments
Open

client: Object search response payload is unverified #657

cthulhu-rider opened this issue Dec 9, 2024 · 0 comments
Labels
bug Something isn't working client Issue related to the client

Comments

@cthulhu-rider
Copy link
Contributor

server responds to ObjectService.Search with stream of messages containing sets of object IDs. Each object ID must be 32 byte len

Current Behavior

if the next ID has an invalid length:

  • Read leaves buffer cell uninitialized w/o an error
  • Iterate passes the last valid ID into handler w/o an error

Expected Behavior

op is failed on any invalid ID

Possible Solution

check and fail

Steps to Reproduce

Regression

no

Your Environment

  • Version of the product used: 335d9fe
@cthulhu-rider cthulhu-rider added bug Something isn't working client Issue related to the client labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client Issue related to the client
Projects
None yet
Development

No branches or pull requests

1 participant