Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Type field of object GetRangeHash is ignored #663

Open
cthulhu-rider opened this issue Dec 10, 2024 · 0 comments
Open

client: Type field of object GetRangeHash is ignored #663

cthulhu-rider opened this issue Dec 10, 2024 · 0 comments
Labels
bug Something isn't working client Issue related to the client I4 No visible changes S4 Routine U3 Regular
Milestone

Comments

@cthulhu-rider
Copy link
Contributor

Client ignores https://github.com/nspcc-dev/neofs-api/blob/e66b25d4bf2afc4472023e1e2c2467f694f5a0e1/object/service.proto#L699. Now server can respond with any value, even negative

no error may be OK when value is unset. Its presence in the protocol is very questionable to me

Current Behavior

field is ignored

Expected Behavior

field is verified

Possible Solution

require equality to the requested one. As option, also allow zero

Steps to Reproduce

Regression

no

@cthulhu-rider cthulhu-rider added bug Something isn't working client Issue related to the client discussion Open discussion of some problem labels Dec 10, 2024
@roman-khimov roman-khimov added U3 Regular S4 Routine I4 No visible changes and removed discussion Open discussion of some problem labels Dec 17, 2024
@roman-khimov roman-khimov added this to the v1.0.0-rc13 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client Issue related to the client I4 No visible changes S4 Routine U3 Regular
Projects
None yet
Development

No branches or pull requests

2 participants