Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check opened issues before tests running #773

Open
evgeniiz321 opened this issue Apr 2, 2024 · 2 comments
Open

Check opened issues before tests running #773

evgeniiz321 opened this issue Apr 2, 2024 · 2 comments
Labels
feature Completely new functionality I2 Regular impact S3 Minimally significant U4 Nothing urgent

Comments

@evgeniiz321
Copy link
Contributor

If there is an open issue with the test name in it's description, e.g. an issue in the rest gateway because of which some tests (test_put_with_bearer_when_eacl_restrict) fail, we need a way to understand it from the test itself and skip this test.

Describe the solution you'd like

Add a custom hook that will be called during pytest test collection phase. This hook will need to go to github and parse opened issues for projects - neofs-node/neofs-s3-gw/neofs-rest-gw.
There should be a certain field in issues' descriptions to be parsed by this hook.

@evgeniiz321 evgeniiz321 added I2 Regular impact feature Completely new functionality labels Apr 2, 2024
@roman-khimov
Copy link
Member

Very fragile to me.

@roman-khimov roman-khimov added U4 Nothing urgent S4 Routine S3 Minimally significant and removed S4 Routine labels Apr 2, 2024
@evgeniiz321
Copy link
Contributor Author

The other way is just to manually update tests and add skips for tests with opened issues. This is not very convenient either and leads to almost useless PRs or just to failed tests. It should be done somehow automatically. But I do not see any other way how to link a github issue to a test besides the description field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Completely new functionality I2 Regular impact S3 Minimally significant U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

2 participants