Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump System.Threading.Tasks.Extensions #653

Closed
benoitdion opened this issue Apr 22, 2021 · 7 comments
Closed

Bump System.Threading.Tasks.Extensions #653

benoitdion opened this issue Apr 22, 2021 · 7 comments

Comments

@benoitdion
Copy link

I realize this might be a big ask but would it be possible to release a new 4.x version with a more recent version of System.Threading.Tasks.Extensions? This will make consuming NSubstitute with Unity a bit easier when other libraries bring in newer versions of the tasks extensions. Unfortunately, Unity doesn't support assembly binding redirect the same way regular dot net projects do.

@dtchepak
Copy link
Member

Hi @benoitdion ,

Which 4.x version did you want the later System.Threading.Tasks.Extensions in? Current NSub supports 4.3+.

Happy to try to make things easier with Unity!

@benoitdion
Copy link
Author

Awesome! 4.5.3 would be great. FWIW this happens to be the version that would work best for me based on other dependencies on the project and also happen to be the latest version at this time. 4.5.3 doesn't improve compatibility with Unity, it just makes it easier to my own use case.

In general though, keeping the transitive dependencies up to date is likely to cause fewer issues over time.

@dtchepak
Copy link
Member

Is it fine to make the change from next NSub release (4.2.x or 4.3.x etc)? Or you need it from an older release?

If you add an explicit project reference to System.Threading.Tasks.Extensions 4.5.3 what problems does that cause in a project referencing NSub? (I thought NSubstitute will use the later version without any problems.)

@benoitdion
Copy link
Author

Off of 4.2.2 would be perfect!

Unfortunately, it seems Unity requires a perfect match in some situations :(.

@304NotModified
Copy link
Contributor

304NotModified commented Apr 29, 2024

I see 5.1 is still using System.Threading.Tasks.Extensions 4.3+.

But of course, you could use a newer version in your code.

@dtchepak I think we don't have plans to change this? Should we close this one?

@dtchepak
Copy link
Member

I see 5.1 is still using System.Threading.Tasks.Extensions 4.3+.

But of course, you could use a newer version in your code.

@dtchepak I think we don't have plans to change this? Should we close this one?

Yes I never got around to this. 😞

I'll close, but please re-open if there are continued problems with Unity and we'll re-evaluate.

@304NotModified 304NotModified closed this as not planned Won't fix, can't repro, duplicate, stale Apr 30, 2024
@304NotModified
Copy link
Contributor

To avoid confusing, I'm marking this as not plannend instead of completed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants