Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not use an <hr /> as a divider #1443

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

haideralsh
Copy link
Contributor

Description

Replaces the underlying HTML for the component while keeping the same API.

Changes include

  • breaking change: a change that is not backwards-compatible and/or changes current functionality
  • fix: a non-breaking change that solves an issue
  • feature: a non-breaking change that adds functionality
  • chore: contains no changes affecting the library, such as documentation or test updates

Feature checklist

  • Appropriate tests have been added
  • Documentation has been updated
  • Accessibility has been considered

@jherdman
Copy link
Contributor

I'm curious about the motivation. <hr is defined as a thematic break between paragraphs. Is the motivation purely semantic or otherwise?

@haideralsh haideralsh marked this pull request as ready for review September 21, 2024 18:07
@haideralsh
Copy link
Contributor Author

@jherdman I saw that we have many instances where we use the divider for visual spacing purposes, improving readability or grouping related fields, rather than to indicate major thematic breaks.

@haideralsh haideralsh merged commit 76a3891 into master Sep 24, 2024
5 checks passed
@haideralsh haideralsh deleted the do-not-use-an-hr-as-a-divider branch September 24, 2024 18:49
github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
## [10.2.13](v10.2.12...v10.2.13) (2024-09-24)

### Bug Fixes

* do not use an <hr /> as a divider ([#1443](#1443)) ([76a3891](76a3891))
Copy link

🎉 This PR is included in version 10.2.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants