Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: StatusIndicator spacing and flexbox bug #584

Merged
merged 5 commits into from
Mar 19, 2020

Conversation

nikola-nulogy
Copy link
Contributor

@nikola-nulogy nikola-nulogy commented Mar 17, 2020

  • The default margin was eliminated by adding default margin props
  • Typography and flexbox style props were added
  • StatusIndicator was made more resilient in flexbox
  • Documentation was updated

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Documentation only

Checklist

Please check all that apply.

  • Storybook updated with examples of new functionality
  • Storybook uses variable and realistic data (ex: short and long text)
  • Docs updated with correct props and examples
  • Updated and reviewed changes to storyshots
  • e2e tests added for component interations
  • jest tests added for component API that may not be captured with storyshots (change handlers, renderers etc)
  • Accessibility (includes relevant tags, keyboard functionality, colour contrast)

Before Merging

  • Tested storybook deployment preview
  • Tested docs deployment preview

@nikola-nulogy nikola-nulogy changed the title Status indicator bug bug: Status indicator bug Mar 17, 2020
@nikola-nulogy nikola-nulogy changed the title bug: Status indicator bug fix: Status indicator bug Mar 17, 2020
@nikola-nulogy nikola-nulogy changed the title fix: Status indicator bug fix: StatusIndicator spacing and flexbox bug Mar 17, 2020
@nikola-nulogy nikola-nulogy merged commit c8642a2 into master Mar 19, 2020
@matthewlyle matthewlyle deleted the status-indicator-bug branch August 27, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants