Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Simplified Chinese #688

Merged
merged 6 commits into from
Jun 25, 2020

Conversation

matthewlyle
Copy link
Contributor

Description

Include what change you're making, why, and link to any relevant JIRA issues

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Documentation only

Checklist

Please check all that apply.

  • Storybook updated with examples of new functionality
  • Storybook uses variable and realistic data (ex: short and long text)
  • Docs updated with correct props and examples
  • Updated and reviewed changes to storyshots
  • e2e tests added for component iterations
  • jest tests added for component API that may not be captured with storyshots (change handlers, renderers etc)
  • Accessibility (includes relevant tags, keyboard functionality, colour contrast)

Before Merging

  • Tested storybook deployment preview
  • Tested docs deployment preview

@marboro92 marboro92 force-pushed the DO-10-Support-Simplified-Chinese branch from 890c33e to 6027614 Compare June 25, 2020 14:42
@matthewlyle matthewlyle merged commit 4a46f83 into master Jun 25, 2020
@matthewlyle matthewlyle deleted the DO-10-Support-Simplified-Chinese branch June 25, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants