Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit figma - asset page #2233

Closed
sync-by-unito bot opened this issue Oct 28, 2022 · 19 comments
Closed

Fit figma - asset page #2233

sync-by-unito bot opened this issue Oct 28, 2022 · 19 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Oct 28, 2022

compare figma design & current capture app:
https://docs.google.com/presentation/d/1u6-l_xDVBcPc708B3TR13DBKAoySjfKu7Hp-PGkfni0/edit#slide=id.g1746b1795ba_0_79

  1. Registered time will display creator name below
  2. Show More under metadata

User story
As a capture app user, I want asset page which fit figma design, so that I can feel the brand design is consistent.

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Oct 28, 2022

➤ Kenny Hung commented:

#2, should need to figure out what other information we are showing with Noir.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 2, 2022

➤ Kenny Hung commented:

If we get the UI/UX suggetions from Noir, arange it into 1107 sprint.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 9, 2022

➤ Ethan Wu commented:

Kenny Hung from the figma it also looks like there is a bigger space between the metadata and the user profile. (48px). did we want to replicate this effect?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 9, 2022

➤ Kenny Hung commented:

Ethan Wu I think yes, except we have additional concerns about the design.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 9, 2022

➤ Ethan Wu commented:

Kenny Hung so yes add 48px between profile pic & metadata

did we get feedback from Noir about the "Show More" Field?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 9, 2022

➤ Ethan Wu commented:

Kenny Hung "Registration Time" under Creator information is not provided by storage backend. cannot add this in until we have storage backend support

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 9, 2022

➤ Kenny Hung commented:

Ethan Wu

  1. "show more" part doesn't get yet, confirm with Noir again.
  2. Registration time part, I create new card for it. [FR] support display account registered ( https://app.asana.com/0/1201083422707776/1203328697415720/f )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 9, 2022

➤ Ethan Wu commented:

Kenny Hung on the figma it looks like there is an image gradient behind the actual photo itself (see top bar) with some opacity. are we looking to add that as well?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 9, 2022

➤ Kenny Hung commented:

Ethan WuTammy Yang about image gradient on top bar , I think we don't need add this, because I found the IG or other app doesn't have have this one, it should be img embedded in figma frame.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 10, 2022

➤ Ethan Wu commented:

so is this ok? see here:

Comment by @Ethan Wu on Update prod page to fit Figma design ( https://app.asana.com/0/0/1203256674737280/1203329790299737/f )

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 14, 2022

➤ Ethan Wu commented:

Kenny Hung any comments on "see more"?

@sync-by-unito sync-by-unito bot closed this as completed Nov 16, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 16, 2022

➤ Ethan Wu commented:

added mimetype, hash and signature to see more section.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 18, 2022

➤ Kenny Hung commented:

Ethan Wu on asset page the metadata have too much space

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 20, 2022

➤ Ethan Wu commented:

Ok this spacing issue happens on the profile page. I'll adjust

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 21, 2022

➤ Kenny Hung commented:

Spacing issue is fixed & registered time will implement in the future sprint. Conditional pass.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Nov 25, 2022

➤ Kenny Hung commented:

Need to complete Registered time in the future, incomplete and re-arrange it.

@sync-by-unito sync-by-unito bot changed the title Update Asset page to fit the figma design Fit figma - asset page Jan 6, 2023
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 6, 2023

➤ Ethan Wu commented:

Kenny Hung to verify this task is to add the registration under the username right?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 6, 2023

➤ Kenny Hung commented:

yes.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jan 18, 2023

➤ Ethan Wu commented:

"member since " added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant