Model scope call after relation returns Builder #319
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently code like this
$this->hasOne(User::class)->active();
results in error sayingCall to an undefined method Illuminate\Database\Eloquent\Relations\HasOne::active()
. This PR fixes this.Relation
class in Laravel forwards unknown calls toBuilder
. AndBuilder
can call scope methods on the model. So it is safe to call model scopes from the relation, like above.There was one issue that I couldn't solve. As far as my understanding goes for the Reflection and PHPStan, there is no way to know the calling context from the reflection.
So in this implementation, I'm treating every unknown call as a scope method call, if the method doesn't also exist in
Builder
I'm open to suggestions if anyone knows how to get the actual scope method reflection from inside the
ModelScopeAfterRelations
pipe.