Fix service provider detection #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyberiaResurrection
force-pushed
the
FixServiceProviderDetection
branch
2 times, most recently
from
28dcf7d to
7816e14
Compare
canvural
requested changes
Feb 3, 2020
CyberiaResurrection
force-pushed
the
FixServiceProviderDetection
branch
2 times, most recently
from
47eccf9 to
a4d930b
Compare
canvural
requested changes
Feb 3, 2020
CyberiaResurrection
force-pushed
the
FixServiceProviderDetection
branch
2 times, most recently
from
8588793 to
b1daff2
Compare
canvural
approved these changes
Feb 4, 2020
|
If you can rebase with the current master, it is good to go 👍 |
CyberiaResurrection
force-pushed
the
FixServiceProviderDetection
branch
from
b1daff2 to
0f03d71
Compare
|
@canvural , that's rebased as requested - thanks again for your help and patience. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in Oct 2019, my original changes (#318 ) to introduce service provider detection implicitly assumed all such providers were concrete.
My own work since has falsified that assumption, so I'm tightening the requirements here.