Go straight to binary instead of relying on composer parser #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It works for me on Windows in Homestead. @deleugpn But it wouldn't run anymore, if you would work with Xampp on Windows. |
|
Thanks! 👍 Looks like the only issue now is that doesn't work with Xampp on Windows. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, sorry I'm a little late on my promise, but here is the fix for #35
When I was fixing this for Laravel Dusk, I learned that relying on
vendor/binwas the root of the problem (as seen here laravel/dusk#244).Just as a quick context for this, the problem happens because composer is smart enough to generate OS-specific binaries at /vendor/bin. Whenever we use a Virtual Machine from Windows to Linux, although the OS is Linux, the Filesystem is still NTFS and Composer does not work really well when guessing the wrapper for the binary.
By going straight to the source (PHP file), we don't rely on composer parser and any platform knows how to execute php files.
NOTICE: Unfortunately I did not have time to test this on a Windows machine, if @Braunson or @MaxwellHutt could give a hand on this, it would be awesome.