fix bootstrap path #852
Merged
fix bootstrap path #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szepeviktor
reviewed
Jun 30, 2021
Co-authored-by: Viktor Szépe <[email protected]>
szepeviktor
approved these changes
Jun 30, 2021
|
Thank you! |
|
It looks like it breaks phpstan when using vendor-bin in an application as the I'm having |
|
@bastien-phi Thank you for your report. |
|
@bastien-phi Is this a Laravel app or a package? |
3 tasks
rajyan
added a commit
to rajyan/larastan
that referenced
this pull request
Jul 2, 2021
This reverts commit d8d1a90.
3 tasks
canvural
pushed a commit
that referenced
this pull request
Jul 2, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I want to re-open this PR #851.
This PR would enable running larastan without caring about the working directory.
As I mentioned in #851, Laravel's bootstrap and vendor path are hardcoded, and should always be a relative path
__DIR__.'/../../../bootstrap/app.php'fromvendor/nunomaduro/larastan.I modified the test a little, and added a test to confirm the changes.
Breaking changes
I think there are no breaking changes.