Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optionally a description to an Insight #8

Closed
nunomaduro opened this issue Apr 3, 2019 · 4 comments
Closed

Add optionally a description to an Insight #8

nunomaduro opened this issue Apr 3, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@nunomaduro
Copy link
Owner

nunomaduro commented Apr 3, 2019

To solve this issue, you should create an interface called HasDescription, that can be added to an Insight. The goal: If an Insight contains the interface HasDescription, then we description somewhere why the Insight exists, why is bad, suggestion on how can be fixed; etc.

@nunomaduro nunomaduro added the enhancement New feature or request label Apr 3, 2019
@akosglue
Copy link

It would be nice by this enhancement if you could include a link to explanations.
For example: if you get this advice: Disallow yoda comparison, there should be a link that will show you the explanation: https://github.com/slevomat/coding-standard#slevomatcodingstandardcontrolstructuresdisallowyodacomparisonrequireyodacomparison-

@JacobDB
Copy link

JacobDB commented May 29, 2019

I'd very much like this as well – phpinsights in my first foray in to automated testing of PHP, so I've been routinely confused by the notices that pop up, and unable to track down any documentation for most of them.

@Jibbarth
Copy link
Collaborator

Jibbarth commented Jul 2, 2019

@akosglue & @JacobDB

Since your comments, we have work on documentation to list all Insights used in phpinsights with their className and their meaning 😉

@nunomaduro
Copy link
Owner Author

No plans to work on this at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants