fix: fix doNotTrack polyfill #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-yao
changed the title
pi0
changed the title
|
Thanks @tim-yao <3 Also updated gist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
The
doNotTrackpollyFill code snippet from https://gist.github.com/pi0/a76fd97c4ea259c89f728a4a8ebca741 is not working for me ifwindow.doNotTrackis0butnavigator.doNotTrackis1. That is Chrome behaviour, that means this DNT validation is not working for most of the users.The parameter
nget a string value'navigator', which is used as an object inn[d]andn[m]. As a result, it returnsundefinedinstead of expected result1or0.Solution
Change the argument to
navigatorinstead of'navigator'fixes the issue for me.I also found
window.external.msTrackingProtectionEnabledpart has mistake as well. Fixed in second commit.