Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar popover issues with hover mode #315

Closed
3 tasks
benjamincanac opened this issue Apr 11, 2022 — with Volta.net · 7 comments · Fixed by nuxt/ui#48
Closed
3 tasks

Navbar popover issues with hover mode #315

benjamincanac opened this issue Apr 11, 2022 — with Volta.net · 7 comments · Fixed by nuxt/ui#48
Labels
bug Something isn't working

Comments

Copy link
Member

benjamincanac commented Apr 11, 2022

  • Delay when hovering
  • Button shouldn't be clickable
  • When moving the mouse between the trigger and the popover, it disappears

I assume this would also be applicable to Dropdown component

@benjamincanac benjamincanac added the bug Something isn't working label Apr 11, 2022 — with Volta.net
Copy link
Contributor

True, I did not disable the click when mode: hover.
But for the 2 others, it is already the case. 100ms is enough to move the cursor from the trigger to the area, tested and approved on Volta back in the days.
So we should just increase the delay.
200ms for the opening delay.

Do you want the delays to be props. I did not make them props, but they were in Volta UI.

Copy link
Member Author

benjamincanac commented Apr 11, 2022

In my opinion there shouldn't be a delay when hovering as there is already a delay with the transition like on click. I'm guessing right now we have the 200 delay on hover and then the transition delay which makes it a total of 400.

Copy link
Contributor

The delay on opening is and was intentionnal, it avoids the case where you quickly pass the cursor over it when accessing something else. We found it anoying to have a dropdown triggering when simply move the cursor up to the browser favorites for example. If I remove this opening delay, we will re-encounter this frustration 😬 But as you wish

Copy link
Member Author

Take a look at https://ionic.io/

Copy link
Contributor

I'll test it, see if only the transition delay works. Hopefully the mechanism will work properly 🤞

Copy link
Contributor

Yes I see and I understand, that is the intention behind this opening delay. I'll remove it and we will work with the transition delay.

Copy link
Contributor

It does not seem good to me. Removing the delay opening, makes isOpen to be true instantly, causing the "container" to be shown. So if I aim for something which is at this place, even if the transition is not complete and the container not visible, the component (Dropdown/Popover) considers the cursor Hover, so it stays opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants