Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Skeleton): add as prop #1955

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

jrutila
Copy link
Contributor

@jrutila jrutila commented Jul 10, 2024

πŸ”— Linked issue

Resolves #1954

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds the as proprety to Skeleton so that the component can be something else than div. Does not break previous use of Skeleton component.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@jrutila
Copy link
Contributor Author

jrutila commented Jul 10, 2024

I checked that the docs should also work. The as property is listed there.

@benjamincanac benjamincanac changed the title feat(Skeleton): as property to change the rendered component feat(Skeleton): add as prop Jul 10, 2024
@benjamincanac benjamincanac merged commit bce94db into nuxt:dev Jul 10, 2024
1 of 2 checks passed
@jrutila jrutila deleted the feature/skeleton-as branch July 10, 2024 12:03
binhtranhuu pushed a commit to binhtranhuu/nuxt-ui that referenced this pull request Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skeleton: as property
2 participants