Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): checkbox can emit the @select event #2072

Merged
merged 10 commits into from
Sep 6, 2024
Merged

Conversation

vanngoh
Copy link

@vanngoh vanngoh commented Aug 21, 2024

πŸ”— Linked issue

Resolves #2064

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Currently clicking the checkbox will not emit the @select event but the checkbox was checked.
This PR is fixing that to make the @select event triggered correctly.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@vanngoh
Copy link
Author

vanngoh commented Sep 6, 2024

@benjamincanac
Sorry to interrupt you, may you take a look on this PR?
I plan to purpose our team to use NuxtUI in production but this table issue is kinda trouble us.

@benjamincanac
Copy link
Member

Sorry for the delay but thanks for the fix! 😊

@vanngoh
Copy link
Author

vanngoh commented Sep 6, 2024

@benjamincanac
Thanks! My pleasure πŸ™Œ

@benjamincanac benjamincanac merged commit b1f691f into nuxt:dev Sep 6, 2024
2 checks passed
binhtranhuu pushed a commit to binhtranhuu/nuxt-ui that referenced this pull request Sep 14, 2024
patrick-hofmann pushed a commit to patrick-hofmann/nuxt-ui that referenced this pull request Oct 3, 2024
@Edd-Luna
Copy link

Edd-Luna commented Oct 11, 2024

hello. IΒ΄m not sure if this is the right place to aks questions, but what if I don't wish that clicking the checkbox can emit the @select event? I'm not sure how to prevent triggering the select function when a checkbox is clicked. My select function opens a new view, but I don't want that to happen while selecting checkboxes in the rows. Thank you, I'll appreciate any guidence on this issue

@sandros94
Copy link
Collaborator

hello. IΒ΄m not sure if this is the right place to aks questions, but what if I don't wish that clicking the checkbox can emit the @select event? I'm not sure how to prevent triggering the select function when a checkbox is clicked. My select function opens a new view, but I don't want that to happen while selecting checkboxes in the rows. Thank you, I'll appreciate any guidence on this issue

Feel free to open a new issue with a reproduction link, or a code example, and tag me in.
But personally, I would use the select function to add those selected rows to an array, and then have a separate function that opens a new view with the currently selected array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UTable doesn't trigger @select when clicking the checkbox
4 participants