fix(Table): select all rows reactivity issue #2200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Resolves #2170
β Type of change
π Description
This PR addresses a reactivity issue with the
selectAllRows
function in the table component. When selecting all rows, the previous implementation usedArray.push()
to modify the array in place, which did not properly trigger Vue's reactivity system. This caused thewatch
on theselected
array not to fire correctly.The solution was to create a new array by spreading
selected.value
, then appending unselected rows to this new array and reassigning it back toselected.value
. This ensures that Vue's reactivity system detects the changes and triggers the necessary updates.π Checklist