Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): customize header and cell through slots #2457

Merged
merged 14 commits into from
Oct 30, 2024
Merged

Conversation

hywax
Copy link
Collaborator

@hywax hywax commented Oct 24, 2024

πŸ”— Linked issue

Resolves #2449, one of the possible #2441 items

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Added support for dynamic scope slots.

Usage:

<template #<column>-header="{ column, header, table }">
  ...
</template>

<template #<column>-data="{ cell, column, getValue, renderValue, row, table}">
  ...
</template>

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@benjamincanac benjamincanac added the v3 #1289 label Oct 28, 2024
@hywax hywax requested a review from benjamincanac October 29, 2024 15:37
Copy link

pkg-pr-new bot commented Oct 30, 2024

pnpm add https://pkg.pr.new/@nuxt/ui@2457

commit: f74e49d

@benjamincanac benjamincanac changed the title feat(Table): add scope slot for column and row feat(Table): customize header and data through slots Oct 30, 2024
@benjamincanac
Copy link
Member

@hywax I've updated the documentation a bit, but I would also rename <column>-data to <column>-cell to match the columns definition. What do you think?

@benjamincanac benjamincanac changed the title feat(Table): customize header and data through slots feat(Table): customize header and cell through slots Oct 30, 2024
@benjamincanac benjamincanac merged commit ef561e7 into nuxt:v3 Oct 30, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants