Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Badge): handle icon and avatar props #2497

Merged
merged 8 commits into from
Nov 5, 2024
Merged

feat(Badge): handle icon and avatar props #2497

merged 8 commits into from
Nov 5, 2024

Conversation

malik-jouda
Copy link
Contributor

@malik-jouda malik-jouda commented Oct 30, 2024 •
edited
Loading

🔗 Linked issue

Resolves #2130

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Screenshot 2024-10-31 at 9 58 40 PM

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 31, 2024 •
edited
Loading 

pnpm add https://pkg.pr.new/@nuxt/ui@2497

commit: ce3e327

@benjamincanac benjamincanac added the v3 #1289 label Oct 31, 2024
@benjamincanac benjamincanac changed the title feat(Badge): support images/icons feat(Badge): add icon and avatar props Nov 5, 2024
@benjamincanac benjamincanac changed the title feat(Badge): add icon and avatar props feat(Badge): handle icon and avatar props Nov 5, 2024
@benjamincanac benjamincanac merged commit 2d52834 into nuxt:v3 Nov 5, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks @malik-jouda! 😊

@malik-jouda
Copy link
Contributor Author

Can I add this in v2? @benjamincanac

@benjamincanac Volta.net
Copy link
Member

Sure you can! 😊

@malik-jouda malik-jouda deleted the feat/badge branch November 6, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees
No one assigned
Labels
v3 #1289
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malik-jouda @benjamincanac