Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(InputMenu/Select/SelectMenu): arrow prop implementation #2503

Merged
merged 6 commits into from
Oct 31, 2024

Conversation

hywax
Copy link
Collaborator

@hywax hywax commented Oct 31, 2024

πŸ”— Linked issue

Resolves #2256

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Implement arrow

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@hywax hywax changed the title feat: arrow prop implementation feat(InputMenu/Select/SelectMenu): arrow prop implementation Oct 31, 2024
Copy link

pkg-pr-new bot commented Oct 31, 2024

pnpm add https://pkg.pr.new/@nuxt/ui@2503

commit: f7590ce

@benjamincanac
Copy link
Member

I've updated the PR a bit to add the documentation sections. However, there is an issue with the SelectArrow in Radix Vue that crashes the component. This is why I commented the ### Arrow section in select.md.

It might be fixed by the Reka UI migration, so I think we can merge as-is.

Thanks! 😊

@benjamincanac benjamincanac merged commit f26f6c8 into nuxt:v3 Oct 31, 2024
2 checks passed
@benjamincanac benjamincanac added the v3 #1289 label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[InputMenu/Select/SelectMenu] Missing arrow prop implementation
2 participants