Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): allow dynamically render checkbox #2549

Merged
merged 18 commits into from
Nov 8, 2024

Conversation

rdjanuar
Copy link
Collaborator

@rdjanuar rdjanuar commented Nov 7, 2024

πŸ”— Linked issue

Resolves #2377, resolves #2222, resolves #2224, resolves #1358

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

New Features

  • Introduced singleSelect prop (default: false) to control how the select function allows only one row to be selected at a time.
  • Added slot select-header allow user to customize column header checkbox interface
  • Added slot select-data allow user to customize row checkbox interface

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

cloudflare-workers-and-pages bot commented Nov 7, 2024

Deploying ui3 with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: 62d9471
Status:🚫  Build failed.

View logs

@rdjanuar rdjanuar marked this pull request as draft November 7, 2024 02:04
@rdjanuar rdjanuar changed the title feat(Table): allow dynamicly render checkbox feat(Table): allow dynamically render checkbox Nov 7, 2024
@rdjanuar
Copy link
Collaborator Author

rdjanuar commented Nov 7, 2024

I should update docs for new slot and give example to hide selected column in header.

@rdjanuar rdjanuar added the enhancement New feature or request label Nov 7, 2024
@rdjanuar rdjanuar marked this pull request as ready for review November 7, 2024 11:21
@rdjanuar rdjanuar marked this pull request as draft November 7, 2024 11:25
@benjamincanac benjamincanac merged commit d6daf46 into dev Nov 8, 2024
2 of 3 checks passed
@benjamincanac benjamincanac deleted the feat/table-improve-selectable branch November 8, 2024 16:24
@benjamincanac
Copy link
Member

benjamincanac commented Dec 11, 2024

@rdjanuar When using a v-model, it seems the first column is erased by the checkbox due to this PR. Could you look into it?

Without v-model:
CleanShot 2024-12-11 at 14 47 26@2x

With v-model:
CleanShot 2024-12-11 at 14 47 33@2x

@rdjanuar
Copy link
Collaborator Author

rdjanuar commented Dec 11, 2024

Okay, i look into it later @benjamincanac

Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants