Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Table): handle meta.class on th and td #2790

Merged
merged 5 commits into from
Dec 2, 2024
Merged

feat(Table): handle meta.class on th and td #2790

merged 5 commits into from
Dec 2, 2024

Conversation

clopezpro
Copy link
Contributor

@clopezpro clopezpro commented Nov 27, 2024 •
edited by benjamincanac
Loading

…meta

🔗 Linked issue

Resolves #2762

❓ Type of change

use custom class in th tag

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

According to the Tanstack documentation, add the ClassName attribute, to add a custom class to the th tag https://tanstack.com/table/v8/docs/api/core/column-def#meta

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

benjamincanac
benjamincanac reviewed Nov 27, 2024
View reviewed changes
Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why className, this is not React 😅

@clopezpro
Copy link
Contributor Author

Why className, this is not React 😅

Could it soon also be called customClass?
image

@benjamincanac Volta.net
Copy link
Member

Just class :)

benjamincanac
benjamincanac requested changes Nov 28, 2024
View reviewed changes
Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be nice to do the same for cells. Also, could you fix the CI?

@benjamincanac benjamincanac changed the title Custom className in th tag feat(Table): handle class on th Nov 28, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 28, 2024 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@2790

commit: 5c0d200

@benjamincanac benjamincanac changed the title feat(Table): handle class on th feat(Table): handle meta.class on th and td Dec 2, 2024
@benjamincanac benjamincanac merged commit 004a577 into nuxt:v3 Dec 2, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks 😊

@benjamincanac benjamincanac added the v3 #1289 label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees
No one assigned
Labels
v3 #1289
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v3] Custom class to the tag <th>
2 participants
@clopezpro @benjamincanac