-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DropdownMenu/ContextMenu): correct bindings of checkbox
items
#2921
Conversation
commit: |
Thanks for the fix! Would you mind doing the same thing on the |
I'm wondering if we should not use the same syntax as well: I missed that when migrating to Reka UI but I would have probably renamed it. |
I also agree to change it so that it is the same as the renka ui, it will make maintenance easier in the future |
reka-ui
syntax for checkbox
items
Can you take care of it or do you want me to do it? |
You can do it, I won't have time now to make all the changes and test it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I think of it, I'm not really sure we should rename all of this since it only applies to items with type checkbox
. Let's merge this for now to fix the issue and figure it out later!
reka-ui
syntax for checkbox
itemscheckbox
items
π Linked issue
Resolves #2892
β Type of change
π Description
This PR fixes the DropdownMenu.CheckboxItem, which now uses the modelValue property instead of :checked and @update:checked. According to the official documentation (https://reka-ui.com/docs/components/dropdown-menu#checkboxitem), the :checked and @update:checked properties are no longer available.
π Checklist