Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SelectMenu): handle resetSearchTermOnBlur manually #3082

Merged
merged 15 commits into from
Jan 13, 2025

Conversation

rdjanuar
Copy link
Collaborator

@rdjanuar rdjanuar commented Jan 13, 2025

πŸ”— Linked issue

Resolves #2912

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

pkg-pr-new bot commented Jan 13, 2025

npm i https://pkg.pr.new/@nuxt/ui@3082

commit: e8a125f

@rdjanuar rdjanuar marked this pull request as draft January 13, 2025 08:01
@rdjanuar rdjanuar marked this pull request as ready for review January 13, 2025 08:07
@rdjanuar rdjanuar marked this pull request as draft January 13, 2025 08:17
@rdjanuar
Copy link
Collaborator Author

My solution works, but it's a hacky approach. I should check the reka-ui source code first to understand how resetSearchTermOnBlur works to properly fix this issue.

@rdjanuar rdjanuar marked this pull request as ready for review January 13, 2025 08:35
@rdjanuar
Copy link
Collaborator Author

code

This is how the resetSearchTerm works in ComboboxInput. Since we use the displayValue prop inside <ComboboxInput />, I think my solution is relevant. wdyt @benjamincanac?

@benjamincanac benjamincanac added the v3 #1289 label Jan 13, 2025
@benjamincanac benjamincanac changed the title fix(SelectMenu): resetSearchTermOnBlur does not work fix(SelectMenu): handle resetSearchTermOnBlur manually Jan 13, 2025
@benjamincanac
Copy link
Member

benjamincanac commented Jan 13, 2025

I agree this a bit hacky and is supposed to be fix in Reka UI but your solution is simple enough for now. Thanks! 😊

@benjamincanac benjamincanac merged commit c902a40 into nuxt:v3 Jan 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3: SelectMenu search input never resets
2 participants