-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FormField): set aria-describedby
and aria-invalid
attributes
#3123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying ui3 with Β
|
Latest commit: |
96c772f
|
Status: | Β β Β Deploy successful! |
Preview URL: | https://e0acca25.ui-6q2.pages.dev |
Branch Preview URL: | https://feat-form-a11y.ui-6q2.pages.dev |
benjamincanac
approved these changes
Jan 17, 2025
@romhml It seems the tests don't pass on Vue because ids look like |
Thanks @benjamincanac I'll look into it! |
@benjamincanac it should be good to go! |
commit: |
aria-describedby
and aria-invalid
attributesaria-describedby
and aria-invalid
attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Resolves #3111
β Type of change
π Description
Adds accessibility attributes on FormField and relevant inputs. This PR also adds tests for the label for=... input binding and fixes said binding on the Select component.
π Checklist