-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SelectMenu): allows to clear search query on close #968
feat(SelectMenu): allows to clear search query on close #968
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
4ec6a02
to
ee38dfd
Compare
I reworked this PR to only clear the search query on close. In other words, the search input becomes empty when:
When the user selects multiple options, the menu doesn't close. This makes clear on update unnecessary. Also, it's not expected the option will change while the menu is open, so there is no need to clear on update. |
Would you mind explaining the difference with #890? I now have to choose between both π |
Sorry! When I made it I just oversaw it on the pulls. The main difference is that the search query is kept as-is by default, where as #890 does not (clears on close by default). But #890 adds a global config to enable or disable this. I'll add that too. |
π Linked issue
Resolves #883
β Type of change
π Description
Currently,
<USelectMenu>
doesn't clear the search query when an option is selected, or when the menu is closed by selection.This allows to clear it when the menu is closed, by either manually closing it or selecting an option, by using the attribute
clear-search-on-close
.π Checklist