Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Slideover): add close button in header #65

Merged
merged 2 commits into from
Jun 24, 2022
Merged

feat(Slideover): add close button in header #65

merged 2 commits into from
Jun 24, 2022

Conversation

smarroufin
Copy link
Collaborator

Left side
Screenshot 2022-06-24 at 13 39 30
Right side
Screenshot 2022-06-24 at 13 39 40

@smarroufin smarroufin requested a review from benjamincanac June 24, 2022 11:41
@vercel
Copy link

vercel bot commented Jun 24, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ❌ Failed (Inspect) Jun 24, 2022 at 1:34PM (UTC)

@netlify
Copy link

netlify bot commented Jun 24, 2022 •
edited
Loading

✅ Deploy Preview for nuxthq-ui canceled.

Name Link
🔨 Latest commit 479a971
🔍 Latest deploy log https://app.netlify.com/sites/nuxthq-ui/deploys/62b5bd47f5fed200099c11aa

benjamincanac
benjamincanac requested changes Jun 24, 2022
View reviewed changes
Copy link
Member

@benjamincanac benjamincanac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expose isOpen to the #header slot instead of hard-coding the button here.

@benjamincanac benjamincanac merged commit 2f90ce2 into dev Jun 24, 2022
@benjamincanac benjamincanac deleted the feat/slideover-close-button branch June 24, 2022 13:40
benjamincanac referenced this pull request in benjamincanac/ui3 Mar 27, 2024
@benjamincanac
feat(Switch): handle loading and loadingIcon
8fd3693 
Resolves #65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smarroufin @benjamincanac