UI Automation in Windows Console: make default in FORMATTED consoles (Windows 11 Sun Valley 2) #10964
Conversation
|
Hi, actually you might want to clarify that legacy consoles will be in effect for 20H2 and earlier so Version 2004 can be covered (note that even in Version 2004, newer Windows Terminal preview release may contain UIA console improvements, and checking for 21H1 property says “True”). Thanks.
|
This comment has been minimized.
This comment has been minimized.
|
Hi, if possible, revert the submodule commit, do git submodule update based on master branch, and commit the rest. Thanks.
|
How so? That property is on |
codeofdusk
force-pushed
the
cmduia-default-21H1
branch
from
93323c3 to
66c56b9
Compare
|
Hi, if I do `focus.UIATextPattern.GetVisibleRanges().length == 1` from Windows Terminal preview, it returns True (but then again, I might be doing something wrong). Another way to specify 21H1 when we don’t know the build is specifying the first build where the new routine appeared (in this case, 19603, and I can confirm the new console UIA support can be enabled). Thanks.
|
codeofdusk
force-pushed
the
cmduia-default-21H1
branch
from
66c56b9 to
1d001b5
Compare
|
Yes. Since Windows Terminal always has a correct UIA implementation, |
feerrenrut
added
app/windows-terminal
|
@codeofdusk could you update the description to summarize what is rolled back in the two PR's you link to and also summarize the two microsoft/terminal PR's. |
|
I've updated the description. |
|
@feerrenrut How can I re-label this PR as Windows Console, not Windows Terminal? |
feerrenrut
added
app/windows-console
|
Most of the PR seems to be referring to terminal and the microsoft/terminal repo. Can you make the description clearer? |
|
Yes, because the terminal repo contains both Windows Terminal and Windows Console source code. |
codeofdusk
force-pushed
the
cmduia-default-21H1
branch
from
1d001b5 to
b2910a5
Compare
|
Will this PR merge NVDA2020.2? |
Probably not, as there are still blocking issues on the conhost side. Once the conhost issues are fixed we can look at merging this. |
codeofdusk
force-pushed
the
cmduia-default-21H1
branch
from
b2910a5 to
49f8936
Compare
|
@feerrenrut @michaelDCurran Could this PR please be labelled as blocked until the blocking PRs are merged? Also CC @carlos-zamora, @DHowett. |
This comment was marked as off-topic.
This comment was marked as off-topic.
codeofdusk
force-pushed
the
cmduia-default-21H1
branch
from
1075633 to
9c212e6
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@seanbudd Thanks for approving! I'm not sure why the system tests are failing as my changes are unrelated. |
It was requested in nvaccess#10964 (comment) that the ternary option be exposed separately to the change in default behaviour to ease revertability. This commit exposes the ternary option as requested and updates the user guide in preparation for PR nvaccess#10964. Co-authored-by: Łukasz Golonka <[email protected]>
It was requested in nvaccess#10964 (comment) that the ternary option be exposed separately to the change in default behaviour to ease revertability. This commit exposes the ternary option as requested and updates the user guide in preparation for PR nvaccess#10964. Co-authored-by: Łukasz Golonka <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
…preparation for usage by default (#13807) Summary of the issue: It was requested in #10964 (comment) that the ternary option be exposed separately to the change in default behaviour to ease revertability. Description of how this pull request fixes the issue: Exposes the ternary option as requested and updates the user guide.
Follow-up of nvaccess#13807. Co-authored-by: Łukasz Golonka <[email protected]>
codeofdusk
force-pushed
the
cmduia-default-21H1
branch
from
c2f83a6 to
c80f421
Compare
Fix-up of #10964. Summary of the issue: The link to Expose Text Attributes to UI Automation microsoft/terminal#10336 was broken by t2t preproc directives. Additional clarification on "NVDA API levels" might be appreciated by some users.
Link to issue number:
Supersedes #9771 and #10716. Closes #1682. Closes #8653. Closes #9867. Closes #11172. Closes #11554.
Summary of the issue:
Microsoft has significantly improved performance and reliability of UIA console:
We should enable UIA support on new Windows Console builds by default for performance improvement and controllable password suppression.
Description of how this pull request fixes the issue:
This PR:
apiLevel >= FORMATTED, and use UIA in this case when the user preference is auto. This is the case on Windows 11 Sun Valley 2 (SV2) available now in beta and set for release in the second half of 2022.Testing performed:
Tested the
IMPROVEDandFORMATTEDconsole implementations as my primary command console for over a year (since February 2020) and worked closely with the Windows Console team (especially @carlos-zamora) to verify stability and report/fix issues. Sent test builds of the new console to several others to verify stability and functionality.Known issues with pull request:
In the event that this PR must be reverted, please do a
git revertor the GitHub revert button to roll it back completely (I'm happy to help with conflict resolution should it be necessary). In other words, please do not change the default value of thewinConsoleImplementationoption in the config spec in an attempt to back out this change similar to #10682, as the "auto" option will then not match default behaviour as expected.Change log entry:
== New Features ==
== Changes for Developers ==
conhost.exe) with an NVDA API level of 2 (FORMATTED) or greater, such as those included with Windows 11 version 22H2 (Sun Valley 2), UI Automation is now used by default. (UI Automation in Windows Console: make default in FORMATTED consoles (Windows 11 Sun Valley 2) #10964)