Telescope broken on neovim HEAD

[clason]

Neovim just merged neovim/neovim#13664, which breaks Telescope: Opening any finder (e.g., just :Telescope) yields

E5108: Error executing lua .../packer/start/plenary.nvim/lua/plenary/window/border.lua:138: Vim(autocmd):E680: <buffer=6>: invalid buffer number

I suspect this is due to neovim/neovim@97abf8e, which changed how autocommands are triggered in popups.

[Conni2461]

I haven't updated and i am still in the middle of something so could you try something.
I am currently thinking that we are probably deleting the popups twice now. Can you try to revert these two changes:
nvim-lua/plenary.nvim@8f2babd
nvim-lua/popup.nvim@bc98ca6

[clason]

That doesn't fix it, unfortunately; then I get

E5108: Error executing lua ...ck/packer/start/telescope.nvim/lua/telescope/pickers.lua:343: Invalid window id: 1006

[Conni2461]

Thanks for testing :) I am pretty sure that got us further. I will try to track it down tomorrow morning. I wanted to do some telescope work this weekend anyway, so its at least a little bit maintained while tj is on vacation.

[clason]

In the meantime, for those coming here:

git checkout 4be0e92db01a502863ac4bb26dd0fee16d833145
make
make install

"unbreaks" telescope.

[Conni2461]

nvim-lua/plenary.nvim#155 and nvim-lua/popup.nvim#13 to fix this issue.

@clason I can merge anything into plenary but i don't have write rights for popup. Is there any chance that you can merge things into popup? Otherwise i will write tj in private

[clason]

Can confirm that this fixes the issue!

@Conni2461 I don't have any more rights than you 😞

I think writing TJ is the best option (although he's on vacation); maybe he'll give you the commit bit? (I'd be good to have at least two people with commit access for a critical dependency. Or re-intregrate popup in plenary? That'd cut down a dependency, too!)

[clason]

If all else fails, in the mean time can't you override the popup.create function with the fixed version in telescope? (Lua monkey-patching 4tw!)

[tjdevries]

🎶 🎶 🎶
Listen, baby, ain't no mountain high
Ain't no valley low, ain't no river wide enough, baby
If you need me, call me, no matter where you are
No matter how far, don't worry, baby
Just call my name, I'll be there in a hurry
You don't have to worry
🎶 🎶 🎶

[clason]

aaaand it's fixed :)

[JSchrtke]

Eyyy, thanks for the quick fix people! <3

[R4k4210]

Thanks for your hard work!