install.sh cd-ing glitch when nvm is already installed

[cspotcode]

Reproduction: run the following so that the second time, install.sh detect that nvm is already installed.

$ NVM_DIR=nvm-dir ./install.sh
$ NVM_DIR=nvm-dir ./install.sh

This happens:

=> nvm is already installed in ./nvm-dir, trying to update using git
=> bash: line 72: cd: ./nvm-dir: No such file or directory
bash: line 73: cd: ./nvm-dir: No such file or directory

This happens because line 62 has already cd-ed to nvm-dir.

EDIT: a quick fix would be for line 62 to pushd and then popd immediately afterwards.

[ljharb]

Hmm, I'm not able to reproduce that. In what directory are you running install.sh from?

I do see the logical issue in the code - that should be trivial to fix.

[cspotcode]

I'm running it in /Users/cspotcode/Desktop/nvm-test/. I have git installed, so the install script is using git instead of wget or curl; maybe that's the difference between my system and yours?

[ljharb]

Pretty sure I have git installed ;-)

So you've downloaded install.sh to that dir, and you're pointing NVM_DIR to another empty/nonexistent dir?

[cspotcode]

Here's a full reproduction case. I'm running Mac OSX 10.10.5.

cd ~/Desktop
mkdir issue1137
cd issue1137
mkdir custom-nvm-dir
touch profile
curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.31.2/install.sh | NVM_DIR=custom-nvm-dir PROFILE=../profile bash
curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.31.2/install.sh | NVM_DIR=custom-nvm-dir PROFILE=../profile bash

[ljharb]

Thanks! When I run

cd ~/Desktop
mkdir -p issue1137
cd issue1137
mkdir -p custom-nvm-dir
touch profile
curl -o- https://raw.githubusercontent.com/creationix/nvm/master/install.sh | NVM_DIR=custom-nvm-dir PROFILE=../profile bash
curl -o- https://raw.githubusercontent.com/creationix/nvm/master/install.sh | NVM_DIR=custom-nvm-dir PROFILE=../profile bash

I do still see bash: line 85: cd: custom-nvm-dir: No such file or directory

[ljharb]

K, should be all fixed in latest master, which will be in the next release.