Install fails after successful cloning

[ods94065]

I noticed on Friday that installation of NVM using install.sh was no longer succeeding in my VM image builds. I run NVM installation in a larger install script that uses set -e, and I started noticing that the install script would abort and break the build after the "Cloning" step. Investigating further, it looked like the script was exiting with status 1.

I believe I've traced it to this change – specifically, these lines:

command git clone "$(nvm_source)" "$INSTALL_DIR" \
       || echo >&2 "Failed to clone nvm repo. Please report this!" && exit 1

Bash behavior in this case, IIUC, is to run || before the &&, so that exit 1 is executed whether or not the cloning succeeds.

I am verifying a fix that I intend to submit in a follow-up PR. Thanks!

[ljharb]

@ods94065 thanks for the report! I'm curious why you're using the master install script, instead of the latest tagged version? master is unstable, and only tagged releases are guaranteed to work.

I think your suspicion is correct, and a PR would be great!

[ods94065]

I'm not sure... there's a lot of history in my install script. :-) I'll make that adjustment too. Thanks!