Use BATS for tests

[koenpunt]

As BATS is better maintained and looks nicer than Urchin, I think we should try and see if it behaves better as well.

Its from @sstephenson, which is the creator of rbenv among other things.

Installation of BATS can be done by adding the following to .travis.yml

before_install:
  - sudo add-apt-repository ppa:duggan/bats --yes
  - sudo apt-get update
  - sudo apt-get install bats
script:
  - bats test/bats

[smikes]

I'm looking for a small project to get oriented to nvm -- is this experiment (try porting tests to BATS) still desired? If so, I would do it on a branch in my fork.

[ljharb]

It's definitely still worth investigating.

Any solution that can allow us to specify which shell to run tests on, to split up tests somehow, and to provide setup/teardown facility, would be worth evaluating.

[smikes]

OK. I will take this on. I have a couple of plane flights coming up. ;-)

[smikes]

This is currently in progress. I had some problems making bats play nicely with sourcing the nvm.sh file but eventually worked around them.

Early progress can be seen on the https://github.com/smikes/nvm/tree/bats branch

One useful snippet (that I will save here) is this:

find . -type f | while read f; do echo "@test '$f' {"; sed -e 's/^/#/' "$f"; echo "}"; echo ; done >> ../bats/fast2.bats

This converts a tree full of urchin style tests into a file full of bats style tests, where each bats test gets the name of the urchin test-file, and the contents of each bats test are the commented-out contents of the test file. (This saves switching between source-test and target-test when porting)

[smikes]

Opened a PR (#601) for review of this work. About half-done; I have ported the tests from test/fast (50 tests) and approximately 30 remain.

[ljharb]

Per #601 (comment), BATS is bash-specific and thus can’t work for our needs.