Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add current version on the top of README #1309

Merged
merged 1 commit into from
Nov 17, 2016

Conversation

PeterDaveHello
Copy link
Collaborator

No description provided.

@@ -1,4 +1,4 @@
# Node Version Manager [![Build Status](https://travis-ci.org/creationix/nvm.svg?branch=master)][3]
# Node Version Manager [![Build Status](https://travis-ci.org/creationix/nvm.svg?branch=master)][3] ![nvm version](https://img.shields.io/badge/version-v0.32.1-yellow.svg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds release overhead, or the risk it will go out of date.

Can you verify that make release will update this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes of course 👍 It'll update this part 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to be very explicit - you have actually ran make release manually and verified that it does update it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct:

$ make TAG=0.123.1 release 
=== Bumping version **0.32.1** to **0.123.1** before committing and tagging:
=== TYPE 'proceed' TO PROCEED, anything else to abort: proceed
nvm.sh
 3131:       nvm_echo '0.123.1'
install.sh
 14:   echo "v0.123.1"
README.markdown
 1: # Node Version Manager [![Build Status](https://travis-ci.org/creationix/nvm.svg?branch=master)][3] [![nvm version](https://img.shields.io/badge/version-v0.123.1-yellow.svg)]
 64: curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.123.1/install.sh | bash
 70: wget -qO- https://raw.githubusercontent.com/creationix/nvm/v0.123.1/install.sh | bash
 438: wget -qO- https://raw.githubusercontent.com/creationix/nvm/v0.123.1/install.sh | /bin/bash
 469: [2]: https://github.com/creationix/nvm/blob/v0.123.1/install.sh
package.json
 3:   "version": "0.123.1",
[master de1f255] v0.123.1
 4 files changed, 8 insertions(+), 8 deletions(-)

@PeterDaveHello
Copy link
Collaborator Author

BTW, we'll need to manually change the color to Green or Blue once v1.0 released, any ETA on v1.0 yet?

@ljharb
Copy link
Member

ljharb commented Nov 17, 2016

Wait, why? I thought it'd always be yellow - pre-1.0 is just as green as post-1.0, since "1.0" means literally nothing about the stability of software.

@PeterDaveHello
Copy link
Collaborator Author

Oh okay, that's from the shieds.io version color rule and we are not using that, if the version doesn't mean any stability, that's no need to do that. (But why roadmap for v1.0?)

@ljharb
Copy link
Member

ljharb commented Nov 17, 2016

The roadmap for 1.0 is because users have the mistaken belief that 1.0 means something, and so while lots of users will update to a 1.0, fewer will upgrade to v2 or v3 in the future - so i want nvm to have the ability to update itself before 1.0.

@PeterDaveHello
Copy link
Collaborator Author

Okay, so that's for the users, not for real meaning :) Mind to share your expect ETA of v1.0? Maybe move to another issue for that?

@ljharb
Copy link
Member

ljharb commented Nov 17, 2016

No expected ETA just yet.

@PeterDaveHello
Copy link
Collaborator Author

hmmmm ... next time maybe I should add [skip ci] here

@ljharb
Copy link
Member

ljharb commented Nov 17, 2016

nah, it's best to let CI always run

@ljharb ljharb merged commit 61ae478 into nvm-sh:master Nov 17, 2016
@PeterDaveHello PeterDaveHello deleted the patch-1 branch November 17, 2016 07:09
@PeterDaveHello
Copy link
Collaborator Author

Even there isn't any part have something to do with README? Maybe we can just save the time and resource on CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants