Use Cabal to install shellcheck and upgrade to shellcheck v0.4.5 #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. This can help speed up the apt process since we decrease the complexity of apt sources and package dependencies resolving by dropping an additional ppa source. 2. Stack doesn't update ShellCheck to v0.4.5 after it has been released more than one month, Cabal can provide ShellCheck v0.4.5
We need to use both the exit state and result form the previous commit, so SC2181 should be disabled here.
ljharb
reviewed
Nov 23, 2016
| @@ -269,6 +269,7 @@ nvm_ensure_version_installed() { | |||
| local NVM_VERSION_DIR | |||
| if [ "${EXIT_CODE}" != "0" ] || ! nvm_is_version_installed "${LOCAL_VERSION}"; then | |||
| VERSION="$(nvm_resolve_alias "${PROVIDED_VERSION}")" | |||
| # shellcheck disable=SC2181 | |||
There was a problem hiding this comment.
Filed koalaman/shellcheck#782 to ask about this.
|
Is Cabal going to be faster than Stack here? This shellcheck job took 7:33, and the master one took 2:04, but I realize the caching hasn't kicked in yet. |
|
Of course once we use cache. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.