Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[readme] update OpenSSF Best Practices badge #3168

Closed
wants to merge 1 commit into from

Conversation

Ishmaello
Copy link

No description provided.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would break it, which is why the commit isn’t in master. Why are you making this PR?

@ljharb ljharb marked this pull request as draft August 19, 2023 15:02
@ljharb ljharb added the non-issue / invalid This isn't relevant to nvm, or turned out to be something unrelated. label Aug 19, 2023
@ljharb ljharb closed this Aug 19, 2023
@Ishmaello
Copy link
Author

Ishmaello commented Aug 19, 2023

In need for yarn packages though it kinda practice,the user tends to interact to migrate the code to use AWS sdk for JavaScript (v3). The aim is to start projects in maticnetwork/polygon-edge as user smart contract provider protocol the user is actually starting to figure out which repo to follow from the smart contract given info.I've already run environment in Polygon-edge but runs fails returns "config AWS credintials"

@ljharb
Copy link
Member

ljharb commented Aug 19, 2023

ok, so you're a chat bot?

@Ishmaello
Copy link
Author

Ishmaello commented Aug 19, 2023 via email

@ljharb
Copy link
Member

ljharb commented Aug 19, 2023

Then I'm very confused why yarn or AWS or crypto would be even remotely relevant here, or why you'd open a PR with my own reverted commit.

@Ishmaello
Copy link
Author

Ishmaello commented Aug 19, 2023 via email

@Ishmaello
Copy link
Author

Ishmaello commented Aug 19, 2023 via email

@ljharb
Copy link
Member

ljharb commented Aug 20, 2023

If you have a random question, use stack overflow. Opening a PR on a random project is just making noise.

@Ishmaello
Copy link
Author

Thanks for tip...I didn't mean to make noise next time I'm going through stack overflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-issue / invalid This isn't relevant to nvm, or turned out to be something unrelated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants