Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing an Asset with original filename fails to generate variants #283

Closed
maccadesign opened this issue Jun 2, 2021 · 2 comments
Closed
Labels

Comments

@maccadesign
Copy link

maccadesign commented Jun 2, 2021

Description

When replacing assets with the same filename variants don't regenerate.

To reproduce

Steps to reproduce the behaviour:

  1. Install Image Optimize
  2. Upload an asset
  3. Replace asset using the same filename as original.
  4. Asset is replaced but image variants are not regenerated.

Expected behaviour

Variants should be regenerated

Versions

  • Image Optimize: 1.6.33
  • Amazon S3: 1.2.11
  • Craft version: Craft Pro 3.6.12
@maccadesign maccadesign added the bug label Jun 2, 2021
@maccadesign maccadesign changed the title Replacing an Asset with the original filename fails to generate variants when using Amazon S3 storage Replacing an Asset with original filename fails to generate variants when using Amazon S3 storage Jun 2, 2021
@maccadesign maccadesign changed the title Replacing an Asset with original filename fails to generate variants when using Amazon S3 storage Replacing an Asset with original filename fails to generate variants Jun 4, 2021
@khalwat
Copy link
Contributor

khalwat commented Jun 9, 2021

To be clear, you're using S3 as your asset volume repository here yes?

khalwat added a commit that referenced this issue Jun 10, 2021
@khalwat
Copy link
Contributor

khalwat commented Jun 10, 2021

Addressed in: 0537349

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-imageoptimize": "dev-develop as 1.6.34”,

Then do a composer clear-cache && composer update

@khalwat khalwat closed this as completed Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants