Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react/require-extension is deprecated #164

Closed
tizmagik opened this issue Sep 15, 2016 · 7 comments · Fixed by #165
Closed

react/require-extension is deprecated #164

tizmagik opened this issue Sep 15, 2016 · 7 comments · Fixed by #165

Comments

@tizmagik
Copy link
Contributor

The react/require-extension rule is deprecated. Please use the import/extensions rule from eslint-plugin-import instead.
@cwonrails
Copy link
Contributor

cwonrails commented Sep 15, 2016

This is an upstream issue with eslint-plugin-import. A temporary solution was posted here: airbnb/javascript#978 (comment).

I'd be glad to put in a PR. I've also updated the outdated deps in package.json in my fork, but I can make a clean branch with this change alone.

@ccpricenytimes
Copy link
Contributor

A PR with the change would be awesome @cwonrails Thanks!

@cwonrails
Copy link
Contributor

No problem at all! Incoming now 👍

@tizmagik
Copy link
Contributor Author

Hmm, well we wouldn't want to 'lose' out on this rule necessarily. It's still useful even if it's deprecated. That workaround seems to suggest to disable the rule just to remove the warning that gets logged. I'm not sure that makes sense. Thoughts?

@cwonrails
Copy link
Contributor

Understood. The workaround is to turn it off for that error while also adding the non-deprecated one.

@tizmagik
Copy link
Contributor Author

Ah, gotcha, that sounds good then! 👍 Thanks!

@cwonrails
Copy link
Contributor

Of course! PR here: #165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants