Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mina-signer] Invalid NetworkId for devnet environment #1937

Open
slnowak opened this issue Dec 2, 2024 · 2 comments
Open

[mina-signer] Invalid NetworkId for devnet environment #1937

slnowak opened this issue Dec 2, 2024 · 2 comments

Comments

@slnowak
Copy link

slnowak commented Dec 2, 2024

Looks like a few days ago, MINA changed their internal NetworkId:

{
    "code": 4,
    "message": "Network doesn't exist",
    "description": "The network doesn't exist.",
    "retriable": false,
    "details": {
        "body": [
            "Network_doesn't_exist",
            "mina:testnet",
            "mina:devnet"
        ],
        "error": "You are requesting the status for the network mina:testnet, but you are connected to the network mina:devnet\n"
    }
}

Therefore, I assume this
export type NetworkId = 'mainnet' | 'testnet' | { custom: string };
should be changed to
export type NetworkId = 'mainnet' | 'devnet' | { custom: string }; ?

@slnowak slnowak changed the title Invalid NetworkId for devnet environment [mina-signer] Invalid NetworkId for devnet environment Dec 2, 2024
@hattyhattington17
Copy link
Contributor

Thanks for bringing this up! I'll update that identifier in the SDK, but could you let me know what action you were taking to trigger this error?

@mitschabaude
Copy link
Collaborator

The mina-signer type doesn't have anything to do with connecting to any network, so it must be something else that needs changing!

(mina-signer is just a signing library. and NetworkId just determines a 0 or 1 byte that becomes part of the signed message)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants