Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hash contract storage keys after encrypting #97

Open
armaniferrante opened this issue Mar 24, 2019 · 1 comment
Open

Don't hash contract storage keys after encrypting #97

armaniferrante opened this issue Mar 24, 2019 · 1 comment

Comments

@armaniferrante
Copy link
Contributor

armaniferrante commented Mar 24, 2019

Instead we can just slice the first 32 bytes.

Even better, we can put the encrypted key directly into storage as our storage supports it. However, this would require rewriting all parity state/accounts to support arbitrary length keys, instead of H256.

See here for current implementation.

Note: this requires a state wipe. We should do this in the same pass that we swap out mrae.

For more background, see https://oasis-labs.slack.com/archives/GAX99F0A0/p1553309277351300

@bennetyee
Copy link
Member

See https://github.com/oasislabs/private-rfcs/pull/100 -- do not use mrae.seal for keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants