Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot tests fail if not building in git repository #985

Closed
matthiasbeyer opened this issue Oct 23, 2024 · 2 comments · Fixed by #986
Closed

Snapshot tests fail if not building in git repository #985

matthiasbeyer opened this issue Oct 23, 2024 · 2 comments · Fixed by #986

Comments

@matthiasbeyer
Copy link

matthiasbeyer commented Oct 23, 2024

"cargo-semver-checks [VERSION] ([HASH])",

For our build in nixpkgs, this line fails because there is no hash when building, so the snapshot does not match with ([HASH]).


Edit: Screenshot for transparency:

image

@suaviloquence
Copy link
Contributor

r"cargo-semver-checks \d+\.\d+\.\d+(-[\w\.-]+)? \(\w+(-modified)?\)",

- r"cargo-semver-checks \d+\.\d+\.\d+(-[\w\.-]+)? \(\w+(-modified)?\)",
+ r"cargo-semver-checks \d+\.\d+\.\d+(-[\w\.-]+)? (\(\w+(-modified)?\))?",

should work, I can make a PR later today.

@obi1kenobi
Copy link
Owner

Thank you both! Sorry for the delay, I'm finally back in the game after a bunch of travel and other things going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants