Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we add kafka test container to project #111

Closed
nicklester opened this issue Apr 24, 2020 · 6 comments
Closed

Could we add kafka test container to project #111

nicklester opened this issue Apr 24, 2020 · 6 comments
Labels
enhancement New feature or request stale

Comments

@nicklester
Copy link
Contributor

When working on my previous PR I had to stand up my own kafka cluster in docker to properly test changes. Could we add a test container to the project, onto which we can start to add test cases? Any other suggestions? Happy to implement

@ekoutanov
Copy link
Member

There's a docker-compose setup at the moment in docker-compose/kafka-kafdrop that runs the latest images of kafka and kafdrop; not really for testing, but more for getting started.

Happy for you to have a crack at a test container if you like. It could be quite useful.

1 similar comment
@ekoutanov
Copy link
Member

There's a docker-compose setup at the moment in docker-compose/kafka-kafdrop that runs the latest images of kafka and kafdrop; not really for testing, but more for getting started.

Happy for you to have a crack at a test container if you like. It could be quite useful.

@nicklester
Copy link
Contributor Author

Actually, maybe thinking of using something like embedded kafka to allow us to bring up a single node cluster, write to topics and ensure that the client code in kafdrop works nicely after changes are made. I guess it's just a start..

@ekoutanov
Copy link
Member

Are you thinking of using some sort of browser based testing like Selenium to drive the client? It would certainly be a very nice thing to have.

@ekoutanov ekoutanov added the enhancement New feature or request label Apr 27, 2020
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jan 23, 2022
@github-actions
Copy link

github-actions bot commented Feb 6, 2022

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as completed Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants