Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformatted Java code and added .editorconfig #500

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

Bert-R
Copy link
Collaborator

@Bert-R Bert-R commented Apr 6, 2023

The formatting of the Java code is consistent now, and described in an- .editorconfig file. Next to that, all wildcard imports are replaced with specific ones.

This is a first step toward increasing the consistency of contributions. These are the next steps that I propose to take:

  1. Extend the pull-request-check with the Super-Linter, with the editorconfig-checker enabled.
  2. Create a CONTRIBUTE.md that describes guidelines and instructions for contributions
  3. Create a SonarCloud project and add rules to automate code reviews
  4. Increase test coverage
  5. Make it a rule that PRs come with automated tests

The formatting of the Java code is consistent now, and described in a
.editorconfig file. Next to that, all wildecard imports are replaced
with specific ones.
@Bert-R Bert-R requested review from davideicardi and ekoutanov April 6, 2023 15:16
@davideicardi
Copy link
Collaborator

@Bert-R Nice! Agree with your proposals.
Just a question: what Sonar Cloud will offers that cannot be done with a traditional local linter/code analyzer?

@Bert-R
Copy link
Collaborator Author

Bert-R commented Apr 7, 2023

SonarCloud gives insight in the state of the product and the evolution over time, it provides the feedback on a PR in a nicer way and it gives an easier way to maintain the rules.

@Bert-R Bert-R merged commit 3448606 into master Apr 11, 2023
@Bert-R Bert-R deleted the reformat-java-code branch April 11, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants