Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add favicon #655

Merged
merged 2 commits into from
Jul 8, 2024
Merged

chore: add favicon #655

merged 2 commits into from
Jul 8, 2024

Conversation

jeremysprofile
Copy link
Contributor

@jeremysprofile jeremysprofile commented Jun 26, 2024 •
edited
Loading

SVG already exists, just a matter of including it in the <header>. Fixes #359.

Tested via:

mvn clean package
java --add-opens=java.base/sun.nio.ch=ALL-UNNAMED  \
  -jar target/kafdrop-4.0.2-SNAPSHOT.jar \
  --kafka.brokerConnect=$KAFKA

Results:
image

@jeremysprofile
chore: add favicon
5818964 
SVG already exists, just a matter of including it in the `<header>`.
Bert-R
Bert-R requested changes Jul 6, 2024
View reviewed changes
Copy link
Collaborator

@Bert-R Bert-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution!
Do you mind swapping type and rel, so they match the lines above it?

src/main/resources/templates/lib/template.ftlh Outdated Show resolved Hide resolved
@jeremysprofile jeremysprofile requested a review from Bert-R July 7, 2024 04:06
Bert-R
Bert-R approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@Bert-R Bert-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@Bert-R Bert-R merged commit 3701396 into obsidiandynamics:master Jul 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bert-R Bert-R Bert-R approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremysprofile @Bert-R