Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: PicBedUploader #4418

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

YumeAyai
Copy link

@YumeAyai YumeAyai commented Oct 14, 2024

I am submitting a new Community Plugin

Repo URL

Link to my plugin:

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2][3]:Remember to rename the sample classes to something that makes sense to your plugin. If there are any errors, Obsidian will spit out this class name, so this will be important for users to debug if they need to.

[1]:Please remove anything from the sample plugin that you don't need.

[1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.

[1]:You should change all instances of var to either const or let. var has function-level scope, so it can easily lead to bugs if you're not careful. Here's a pretty good guide with examples of why not to use var: why var is obsolete


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot self-assigned this Oct 15, 2024
@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Oct 15, 2024
@YumeAyai
Copy link
Author

YumeAyai commented Oct 15, 2024

/skip

I believe the requirement to modify CSS is not applicable in this case for the following reasons:

  1. Immediate Feedback: The plugin primarily interacts with child windows for real-time image styling feedback. Inline styles in JavaScript allow for quicker adjustments tailored to immediate user needs.

  2. Simplicity of Styles: The inline CSS is minimal, focusing solely on child window size ratios and image positioning. Given the simplicity of these styles, creating a separate CSS file seems unnecessary.

  3. Reduced Complexity: Managing styles directly within JavaScript keeps the development process straightforward, aligning with the current scope of the project without adding unnecessary complexity.

Additionally, I have made all other necessary modifications as requested. Therefore, I respectfully request to skip the CSS modification requirement.

@github-actions github-actions bot added the Skipped code scan Code scanning skipped because submission is not in TS/author believes result is wrong label Oct 15, 2024
@YumeAyai YumeAyai closed this Oct 20, 2024
@YumeAyai YumeAyai reopened this Oct 20, 2024
@YumeAyai
Copy link
Author

It seems I need to merge to the master branch, but I'm restricted due to write access. Could someone with the appropriate permissions help with the merge, or provide guidance on how to proceed? Thank you!

@YumeAyai YumeAyai changed the base branch from master to submit-cloud-atlas-plugin October 20, 2024 16:53
@YumeAyai YumeAyai changed the base branch from submit-cloud-atlas-plugin to master October 20, 2024 16:55
@Jackie-Li-0228
Copy link

My PR is also encountered the same question.Dont know how to proceed.

@joethei joethei added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Skipped code scan Code scanning skipped because submission is not in TS/author believes result is wrong labels Oct 29, 2024
@joethei
Copy link
Collaborator

joethei commented Oct 29, 2024

Resetting the review bot because the Git history rewrite caused a few issues.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.

[1]:Remember to rename the sample classes to something that makes sense to your plugin. If there are any errors, Obsidian will spit out this class name, so this will be important for users to debug if they need to.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot self-assigned this Oct 30, 2024
@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Oct 30, 2024
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Expected ',' or ']' after array element in JSON at position 518543


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@YumeAyai YumeAyai closed this Nov 15, 2024
@YumeAyai YumeAyai deleted the tmp-pr branch November 15, 2024 17:01
@YumeAyai YumeAyai restored the tmp-pr branch November 15, 2024 17:01
@YumeAyai YumeAyai deleted the tmp-pr branch November 15, 2024 17:01
@YumeAyai YumeAyai restored the tmp-pr branch November 15, 2024 17:02
@YumeAyai YumeAyai deleted the tmp-pr branch November 15, 2024 17:12
@YumeAyai YumeAyai restored the tmp-pr branch November 15, 2024 17:14
@YumeAyai YumeAyai reopened this Nov 15, 2024
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: OmriLeviGit/Automatic-Renumbering-Obsidian. If you are submitting from a GitHub org, you need to be a public member of the org.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

1 similar comment
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: OmriLeviGit/Automatic-Renumbering-Obsidian. If you are submitting from a GitHub org, you need to be a public member of the org.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@YumeAyai YumeAyai closed this Nov 15, 2024
@YumeAyai
Copy link
Author

so that i should wating for merge to master?

@joethei
Copy link
Collaborator

joethei commented Nov 21, 2024

You need to fix the things pointed out by the review bot first.
After that I will review.
Only then will this PR be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Changes requested plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants