-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin: PicBedUploader #4418
base: master
Are you sure you want to change the base?
Conversation
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1][2][3]:Remember to rename the sample classes to something that makes sense to your plugin. If there are any errors, Obsidian will spit out this class name, so this will be important for users to debug if they need to. [1]:Please remove anything from the sample plugin that you don't need. [1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets. [1]:You should change all instances of Do NOT open a new PR for re-validation. |
/skip I believe the requirement to modify CSS is not applicable in this case for the following reasons:
Additionally, I have made all other necessary modifications as requested. Therefore, I respectfully request to skip the CSS modification requirement. |
It seems I need to merge to the master branch, but I'm restricted due to write access. Could someone with the appropriate permissions help with the merge, or provide guidance on how to proceed? Thank you! |
My PR is also encountered the same question.Dont know how to proceed. |
Resetting the review bot because the Git history rewrite caused a few issues. |
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets. [1]:Remember to rename the sample classes to something that makes sense to your plugin. If there are any errors, Obsidian will spit out this class name, so this will be important for users to debug if they need to. Do NOT open a new PR for re-validation. |
Hello!I found the following issues in your plugin submission Errors: ❌ Could not parse This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Hello!I found the following issues in your plugin submission Errors: ❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
1 similar comment
Hello!I found the following issues in your plugin submission Errors: ❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
so that i should wating for merge to master? |
You need to fix the things pointed out by the review bot first. |
I am submitting a new Community Plugin
Repo URL
Link to my plugin:
Release Checklist
main.js
manifest.json
styles.css
(optional)v
)id
in mymanifest.json
matches theid
in thecommunity-plugins.json
file.I have given proper attribution to these other projects in my
README.md
.