-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin: pycalc #4686
base: master
Are you sure you want to change the base?
Add plugin: pycalc #4686
Conversation
Thank you for your submission, an automated scan of your plugin code's revealed the following issues: Required[1]:Remember to rename the sample classes to something that makes sense to your plugin. If there are any errors, Obsidian will spit out this class name, so this will be important for users to debug if they need to. Do NOT open a new PR for re-validation. |
Changes requested by bot have been made, assigning human for additional review. |
I updated the contents of the 1.0.0 release without changing the version, do I need any additional steps? |
Remove the "description": "The pycalc plugin enables the execution of python code directly within the editor upon pressing the Enter key.", python The |
bryton this is not my code, are you sure you need to include the non-minified version? As for brython_stdlib.js, I did not find the non-minified version, it is minified python code in a js wrapper. you can see the diff between my repo and the original from brython other requests have been fulfilled |
Prefered would be if you load |
I can't use brython as a dependency because I made some changes to make brython REPL similar to python REPL and to be able to use brython in my plugin. The line that duplicated the original REPL request was removed from the original brython:
The line for outputting the result in repr format was also changed.
to:
|
Hello!I found the following issues in your plugin submission Errors: ❌ Could not parse This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Hello!I found the following issues in your plugin submission Errors: ❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Hello!I found the following issues in your plugin submission Errors: ❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
Hello!I found the following issues in your plugin submission Errors: ❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it. |
I am submitting a new Community Plugin
Repo URL
Link to my plugin: https://github.com/pycalc-plugin/obsidian
Release Checklist
main.js
manifest.json
styles.css
(optional)v
)id
in mymanifest.json
matches theid
in thecommunity-plugins.json
file.I have given proper attribution to these other projects in my
README.md
.