Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace WalletConnect from unpkg (June 2023) #369

Closed
KatunaNorbert opened this issue Nov 2, 2022 · 4 comments · Fixed by #420
Closed

Replace WalletConnect from unpkg (June 2023) #369

KatunaNorbert opened this issue Nov 2, 2022 · 4 comments · Fixed by #420
Assignees
Labels
Type: Bug Something isn't working

Comments

@KatunaNorbert
Copy link
Member

We currently get WalletConnectProvider from unpkg which is based on an api call. This is not ideal because if the api is down we can't use WalletConnect.
We should find a different way, ideally an npm package to get the WalletConnectProvider.

@KatunaNorbert KatunaNorbert added Type: Bug Something isn't working Priority: High labels Nov 2, 2022
@idiom-bytes
Copy link
Member

There has been a bit of back and forth, whether we can remove or keep the package. We need to continue research and consider what needs to be done here so we can complete this and move on.

  • Based on the initial issue/pr, there have been improvements via cleanup and sorting out dependencies. We however do not have a long term solution for WalletConnect.
  • If WC is down, there isn't much we can do.

We're going to time block this, move to the med-term backlog, and see if we can come back to this in the future.

@idiom-bytes
Copy link
Member

We should also be able to more easily diagnose if this happens again.

Before we really consider removing it all, let's
wait a bit until we run into issues w/ WC again.

@kremalicious
Copy link
Contributor

kremalicious commented Dec 1, 2022

1st step:

Add and import @walletconnect/web3-provider from your local resources, however that works in Svelte to restore current app ASAP. Just npm i @walletconnect/web3-provider and import in your app.

Second step:

Do not spend any more time on the deprecated walletconnect version and upgrade to v2, making @walletconnect/web3-provider obsolete. Kick out all you have for connecting web3 and start fresh from here, using the default web3modal. Then style it a bit to your liking. Done https://docs.walletconnect.com/2.0/web3modal/html-js/installation

@idiom-bytes
Copy link
Member

We're basically waiting for an update from WC and trying to complete the issue due the QR code not working. This is one of the few PRs remaining.

@idiom-bytes idiom-bytes changed the title Replace WalletConnect from unpkg Replace WalletConnect from unpkg (June 2023) Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants