Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: migrate to eslint 9 #122

Merged
merged 15 commits into from
Jan 27, 2025
Merged

feat!: migrate to eslint 9 #122

merged 15 commits into from
Jan 27, 2025

Conversation

mdonnalley
Copy link
Contributor

BREAKING CHANGE: use eslint 9 and assume typescript projects

@W-17599563@

package.json Outdated
"eslint": "^8.57.1"
"@oclif/prettier-config": "^0.2.1",
"eslint": "^9",
"typescript": "^5"
},
"engines": {
"node": ">=18.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@cristiand391 cristiand391 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small request to bump minimum node.
Settings in new config format looks good, I'll verify all work on QA.

@cristiand391 cristiand391 merged commit b683efd into main Jan 27, 2025
7 checks passed
@cristiand391 cristiand391 deleted the mdonnaLley/eslint-9 branch January 27, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants